Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(uikit): uikit interactions #30534

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2023

⚠️ No Changeset found

Latest commit: 3b907d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #30534 (3b907d8) into develop (0838406) will decrease coverage by 0.27%.
Report is 1 commits behind head on develop.
The diff coverage is 52.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30534      +/-   ##
===========================================
- Coverage    51.30%   51.03%   -0.27%     
===========================================
  Files          811      810       -1     
  Lines        15054    15162     +108     
  Branches      2749     2812      +63     
===========================================
+ Hits          7723     7738      +15     
- Misses        6924     6986      +62     
- Partials       407      438      +31     
Flag Coverage Δ
e2e 48.35% <51.93%> (-0.22%) ⬇️
unit 64.04% <27.77%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/uikit-interactions branch 6 times, most recently from 16cb4f5 to 5b60c51 Compare October 6, 2023 07:50
@tassoevan tassoevan force-pushed the refactor/uikit-interactions branch 3 times, most recently from 617c52d to 2730673 Compare October 18, 2023 13:41
@tassoevan tassoevan marked this pull request as ready for review October 18, 2023 13:41
@tassoevan tassoevan requested review from a team as code owners October 18, 2023 13:41
@tassoevan tassoevan force-pushed the refactor/uikit-interactions branch from 2730673 to b312b1e Compare October 18, 2023 17:54
@tassoevan tassoevan force-pushed the refactor/uikit-interactions branch from b312b1e to 3b907d8 Compare October 18, 2023 19:21
@ggazzo ggazzo merged commit 7b02ca3 into develop Oct 19, 2023
41 checks passed
@ggazzo ggazzo deleted the refactor/uikit-interactions branch October 19, 2023 03:09
gabriellsh added a commit that referenced this pull request Oct 20, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  docs: Fixed typo in FEATURES.md (#30683)
  refactor(uikit): uikit interactions (#30534)
  feat: add trial flag to licenses.info endpoint (#30662)
  refactor: Small files to typescript (#30665)
  feat: Added new setting 'Hide conversation after closing' (#30591)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants